(role/fiberspec) add dco class to fiberspec role #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtapiacl
force-pushed
the
IT-5290_update_fiberspec_role
branch
3 times, most recently
from
82ac14d to
72c656e
Compare
Thanks for the feedback i would appreciate your review once more. |
jhoblitt
reviewed
May 6, 2024
jhoblitt
reviewed
May 6, 2024
jhoblitt
reviewed
May 6, 2024
jhoblitt
requested changes
May 6, 2024
There was a problem hiding this comment.
It appears that I messed when reviewing #1134 as there is not a spec file covering this role (there is an auto-magic catchall role test for that cases but it isn't really enough coverage).
Please add a spec/hosts/roles/fiberspec_spec.yaml. Within that file, please include the dco shared example group. E.g. include_examples 'dco'
dtapiacl
force-pushed
the
IT-5290_update_fiberspec_role
branch
2 times, most recently
from
882a415 to
43c1900
Compare
dtapiacl
force-pushed
the
IT-5290_update_fiberspec_role
branch
13 times, most recently
from
9d1a2a6 to
7fb3778
Compare
dtapiacl
force-pushed
the
IT-5290_update_fiberspec_role
branch
10 times, most recently
from
69b81e3 to
39a08bd
Compare
jhoblitt
requested changes
May 17, 2024
dtapiacl
force-pushed
the
IT-5290_update_fiberspec_role
branch
2 times, most recently
from
3520c73 to
6a7b401
Compare
jhoblitt
approved these changes
May 21, 2024
dtapiacl
force-pushed
the
IT-5290_update_fiberspec_role
branch
from
6a7b401 to
78cdaa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.